KozmotronikTech/relay_chn
3
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 10 Wiki Activity

Add tilt feature, fix bugs, improve code. #6

Merged
kozmotronik merged 1 commits from feature-tilt into dev 2025-02-21 10:46:11 +01:00
Conversation 0 Commits 1 Files Changed 3 +443 -26
kozmotronik commented 2025-02-21 10:45:18 +01:00
Owner
Copy Link

  • Add tilt feature.

  • Fix the following bugs:

    • warning: comparison is always true due to limited range of data type.
    • Remove unnecessary esp_timer checks.
    • The scheduled FREE command disrupts the current command.
    • Fatal pin mapping issue.

  • Make code optimizations and improvements:

    • Optimize event loop queue size depending on channel count.
    • Change the channels' starting state to FREE.
    • Remove the unnecessary relay_chn_invalidate_inertia_timer function.
    • Change the relay_chn_start_inertia_timer function as relay_chn_start_esp_timer_once and modify the function so that it be a generic esp timer start function.
    • Optimize the if statement that checks the last run cmd in the relay_chn_execute_stop.

This PR fixes #1, #3, #4, #5 and it closes #2.

* Add tilt feature. * Fix the following bugs: * warning: comparison is always true due to limited range of data type. * Remove unnecessary esp_timer checks. * The scheduled FREE command disrupts the current command. * Fatal pin mapping issue. * Make code optimizations and improvements: * Optimize event loop queue size depending on channel count. * Change the channels' starting state to FREE. * Remove the unnecessary relay_chn_invalidate_inertia_timer function. * Change the relay_chn_start_inertia_timer function as relay_chn_start_esp_timer_once and modify the function so that it be a generic esp timer start function. * Optimize the if statement that checks the last run cmd in the relay_chn_execute_stop. This PR fixes #1, #3, #4, #5 and it closes #2.
kozmotronik added 1 commit 2025-02-21 10:45:19 +01:00
Add tilt feature, fix bugs, improve code. a694938224 
* Add tilt feature.

* Fix the following bugs:
  * warning: comparison is always true due to limited range of data type.
  * Remove unnecessary esp_timer checks.
  * The scheduled FREE command disrupts the current command.
  * Fatal pin mapping issue.

* Make code optimizations and improvements:
  * Optimize event loop queue size depending on channel count.
  * Change the channels' starting state to FREE.
  * Remove the unnecessary relay_chn_invalidate_inertia_timer function.
  * Change the relay_chn_start_inertia_timer function as relay_chn_start_esp_timer_once and modify the function so that it be a generic esp timer start function.
  * Optimize the if statement that checks the last run cmd in the relay_chn_execute_stop.
kozmotronik added this to the ESP Relay Channel Controller Component project 2025-02-21 10:45:19 +01:00
kozmotronik merged commit 7d3f08b56b into dev 2025-02-21 10:46:11 +01:00
kozmotronik moved this to Done in ESP Relay Channel Controller Component on 2025-02-21 12:52:34 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 documentation
Missing or requested documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project ESP Relay Channel Controller Component
Assignees
Clear assignees
ismail kozmotronik
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KozmotronikTech/relay_chn#6
Delete Branch "feature-tilt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?